search

atom / autocomplete-emojis

autocomplete+ emoji autocompletion
https://atom.io/packages/autocomplete-emojis
MIT License
74 stars 20 forks source link

Fix broken images :camera: #18

Closed rsese closed 7 years ago

rsese commented 7 years ago

Created some new images to replace the now broken README images.

/cc @ben3eee @AndreaGriffiths11 for 👓 /cc @robbawebba for reporting the issue :bow:

Fixes https://github.com/atom/autocomplete-emojis/issues/17.

rsese commented 7 years ago

Went ahead and fixed some small capitalization issues:

rsese commented 7 years ago

I'm pretty confident the images are correct after chatting with @ben3eee but let me know if any off them are off or could be better.

The only one I'm maybe not super happy about is the Settings image:

settings

I guess I could crop it down more to just this?

atom-autocomplete-emojis-settings-take-2

Ben3eeE commented 7 years ago

Wow I don't have access to do reviews or anything in this repository.

@rsese I agree that the cropped settings-view image looks better but maybe we should remove the image and just have the text Settings to disable Unicode and/or Markdown emojis instead. I think an image of the available settings doesn't add much. Not all bullet points had images.

rsese commented 7 years ago

Broken images were fixed in https://github.com/atom/autocomplete-emojis/commit/a56ed6373c1b8f40807427d0e42e531583685645, closing this.