atom / autocomplete-emojis

autocomplete+ emoji autocompletion

https://atom.io/packages/autocomplete-emojis

MIT License

74 stars 20 forks source link

Update dev dependency #9

Closed aatrostle closed 8 years ago

aatrostle commented 8 years ago

I think this resolves the issue I opened (https://github.com/atom/autocomplete-emojis/issues/8). After updating grunt-apm I was able to successfully apm link the package. I am just learning about semver, packages, etc, LMK if I missed a step.

Thanks!

eqot commented 8 years ago

8 seems not an issue for users, but an issue for developers.

And this commit looks almost ok, but ideally it should update not only grunt-apm but also other related components like followings, according to david update.

    "grunt": "^1.0.1",
    "grunt-apm": "^1.0.1",
    "grunt-coffee-jshint": "^0.3.0",
    "grunt-contrib-watch": "^1.0.0",

So, can you update your commit like above? Or I can do that by myself.

aatrostle commented 8 years ago

Updated. Neat, I hadn't heard of david before now 👍

eqot commented 8 years ago

Perfect 👍 Thanks!