search

atom / autocomplete-plus

View and insert possible completions in the editor while typing
MIT License
960 stars 263 forks source link

different confirmCompletion default value #1065

Closed pfitzseb closed 4 years ago

pfitzseb commented 4 years ago

Description of the Change

This changes the default value of the confirmCompletion config key to tab always, enter when explicitly selected.

Alternate Designs

None.

Benefits

The current behavior is confusing with the default completions, because basically everything you type will cause the dropdown menu to appear; it's then impossible to insert a new line unless you press Escape first.

Possible Drawbacks

Some people might not like it, but that's the case for all options, so ¯\_(ツ)_/¯.

rsese commented 4 years ago

Thanks for the contribution @pfitzseb! At this point we're generally not changing defaults across Atom unless there's a super compelling reason to do so - after chatting with the other maintainers, while we see what you're talking about with the behavior of default completions and the need to hit enter, we don't think it's enough of a reason to change the default and we'll leave it to people to change the setting if it impacts their workflow. So I'll go ahead and close this out but thanks again for contributing.

pfitzseb commented 4 years ago

Fair enough. Thanks for taking a look at this!