atom / autocomplete-plus

View and insert possible completions in the editor while typing
MIT License
960 stars 263 forks source link

"Keymap for Confirming a Suggestion" option not working #1066

Closed pmalonis closed 4 years ago

pmalonis commented 4 years ago

Prerequisites

Description

"Keymap for Confirming a Suggestion" option not working

Steps to Reproduce

Go to settings for the package. Select "Keymap for Confirming a Suggestion" to any of the options that do not include enter (including "None")

Expected behavior: Enter should not confirm a suggestion except when certain Keymap options are selected

Actual behavior:

Enter confirms selection, including when "None" is selected. However, if I select "Enter" or "None" then Tab does not confirm the selection.

Reproduces how often: Every time.

Versions

Atom : 1.40.1 Electron: 3.1.10 Chrome : 66.0.3359.181 Node : 10.2.0 apm 2.4.3

rsese commented 4 years ago

Thanks for the report! I'm unable to reproduce with 1.40.1 on macOS 10.14.6, I tried setting to Tab and None and in both cases, Enter doesn't confirm a suggestion for me.

Did Atom behave exactly the same when you tried in safe mode? Also, what operating system are you running?

grussy commented 4 years ago

I can confirm this behaviour on ubuntu linux atom --version : 1.35.1

Tried in safe mode: Here the behaviour is as expected, Enter does not confirm suggestions.

Installed Packages: advanced-open-file emacs-plus

Disabling the emacs-plus package solves the problem.

rsese commented 4 years ago

Thanks :+1:

Disabling the emacs-plus package solves the problem.

You can open an issue on their repository: https://atom.io/packages/emacs-plus. Then if there's a problem on the Atom side, they can either fix the problem or tell us where the problem is coming from.

Are you also using emacs-plus @pmalonis?

As a side note:

atom --version : 1.35.1

The current stable version of Atom is 1.41.0 so I'd suggest updating if possible.

no-response[bot] commented 4 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.