search

atom / bookmarks

Bookmark editor lines in Atom
MIT License
49 stars 36 forks source link

Keybindings for other platforms in README.md #43

Closed bekroogle closed 9 years ago

bekroogle commented 9 years ago

Keybindings are in bullet lists, instead of tables as in atom/bookmarks#29

This really needs to exist somewhere. Being new to Atom, I only stumbled upon these bindings when browsing the repo, hoping to learn how to implement them.

winstliu commented 9 years ago

The image will also have to be updated for this since it contains a shot of the README itself...

bekroogle commented 9 years ago

How's this? (I just updated the README.md with the following screenshot.)

atom-bookmarks-screenshot

winstliu commented 9 years ago

Other than my one small comment, could you please take the image in safe mode so that it matches the out-of-the-box experience? Just so others don't get confused when they don't see the linter status :smile:.

bekroogle commented 9 years ago

Okay, I think I got the screenshot right and I removed the extraneous whitespace after "Keybindings".

// Sorry if I've made it a painful process--I haven't done many pull requests before.

winstliu commented 9 years ago

Thanks a lot for this, and don't worry about the process :).

bekroogle commented 9 years ago

My pleasure. It was a good learning experience for me and a nice diversion from real work =] On Oct 11, 2015 6:53 PM, "Wliu" notifications@github.com wrote:

Thanks a lot for this, and don't worry about the process :).

— Reply to this email directly or view it on GitHub https://github.com/atom/bookmarks/pull/43#issuecomment-147256264.

bekroogle commented 8 years ago

@50Wliu, Do you have any idea how we could go about getting this updated README.md and keybindings to be reflected in the page at https://atom.io/packages/bookmarks?

Anyone who clicks on the bookmarks link in Settings > Packages gets sent to the atom.io/packages site, so someone would actually have to seek out this repo to find the keybindings for the other platforms.

mnquintana commented 8 years ago

@bekroogle I just pushed a new patch release for bookmarks, so https://atom.io/packages/bookmarks should be up-to-date now – sorry for the delay!

winstliu commented 8 years ago

Whoops, I forgot all about pushing a new release :grimacing:. Sorry about that!

bekroogle commented 8 years ago

No worries. I only noticed because I hadn't used Atom in a while and couldn't remember the Bookmarks keystrokes, so I clicked the link in the Packages section to be reminded. :)

On Sat, Jan 2, 2016 at 9:26 PM, Wliu notifications@github.com wrote:

Whoops, I forgot all about pushing a new release [image: :grimacing:]. Sorry about that!

— Reply to this email directly or view it on GitHub https://github.com/atom/bookmarks/pull/43#issuecomment-168456231.