search

atom / bookmarks

Bookmark editor lines in Atom
MIT License
49 stars 36 forks source link

Add an option to cycle through bookmarks #63

Open solendil opened 8 years ago

solendil commented 8 years ago

Issues #31 and #50 show that not all users agree on the expected behavior when bottom of buffer has been reached. Should we cycle to top of buffer or stay at the bottom with a 'bip' for a better sense of place? This pull request implements an option (the first one for the bookmarks package!); default behavior is unchanged.

Feel free to change the wording; English is not my mother tongue.

Jasmine specs have been added.

winstliu commented 8 years ago

@solendil @nbigaouette what are your opinions on adding a visual cue that the beginning/end of the file has been reached and the bookmarks have looped? Similar to this PR from find-and-replace: atom/find-and-replace#572.

nbigaouette commented 8 years ago

This PR is exactly what I asked some time ago in #31. But even without it, the visual clue you suggest is an excellent idea.

solendil commented 8 years ago

Wrap around icon added. I didn't bother to put a screenshot because it is exactly the same than the one from the find-and-replace package. In fact I borrowed most of the code from there. I'm not very fond of this code, though. It feels like it should belong to a global notification system.