search

atom / bookmarks

Bookmark editor lines in Atom
MIT License
49 stars 36 forks source link

Clear pending state when setting a bookmark (plus some defensive code) #66

Open solendil opened 8 years ago

solendil commented 8 years ago

58, #57 are related to cases when the bookmark list contain bookmarks for editors that don't exist anymore. There are two cases:

When the editor was pending

I propose to clear the pending status when a bookmark is set. After all, if you set a bookmark on a file, you probably don't want it to disappear when previewing another file.

Other situations where we don't have a clear scenario

I encountered such situations, yet couldn't reproduce them. I propose some simple defensive code: verify that editors are still alive before putting their bookmarks in the list.

winstliu commented 8 years ago

I can't reproduce #58 on pending pane items. The bookmarks list is empty after the preview changes.

edit: your change to make the pending items permanent makes sense though