atom / bookmarks

Bookmark editor lines in Atom
MIT License
49 stars 36 forks source link

Jump to new bookmark (f2) is buggy #69

Closed alanneese closed 8 years ago

alanneese commented 8 years ago

Create new 'Plain Text' file and add six blank lines. Add bookmark to line 1. Add bookmark to line 3. Add bookmark to line 6. At this point F2 cycles through the three bookmarks just fine. Add bookmark to line 4. Pressing F2 now cycles through the line 4 and line 6 only.

This is on a windows machine, Atom 1.10.

bolinfest commented 8 years ago

I'm on 1.10 on OS X. I have two bookmarks in a file: one on line 398 and one on 893. Hitting F2 on either 892 or 894 takes me to 893. Hitting it again doesn't take me anywhere, so I can't get to the one on 398 unless I hit shift-F2.

ghost commented 8 years ago

I'm on 1.9.4 / Windows. Getting the same behaviour as the OP. If you keep adding bookmarks beyond his test case, the behaviour of F2/Shift+F2 gets even more bizarre.

winstliu commented 8 years ago

Confirmed.

rzelnik commented 8 years ago

I am on Ubuntu, Atom 1.10.2. I also can confirm strange behaviour - some bookmarks are ignored.

sebest commented 8 years ago

Also, if you have bookmark in different files: switching using 'view all the bookmarks' does not work. It only works if you select a bookmark that is in the current open file.

HildoBijl commented 8 years ago

Confirmed. I even have a simpler case.

Why this very different behavior? It doesn't make sense to me. (I'm on Windows 10, Atom 1.10.2.)

trentjones21 commented 8 years ago

I am having the same problem as @HildoBijl (macOS Sierra, Atom 1.10.2)

winstliu commented 8 years ago

@as-cii This seems to have broken starting at the v0.39.0 release, which is right after you merged #53.

revelt commented 8 years ago

If I add two bookmarks, F2 cycling works fine. But if I add a bookmark in-between, topmost-one stops working:

bookmarks_ignored

I'm on Atom 1.11.2 on MacOS Sierra

sebest commented 8 years ago

Hi @revelt,

What do you use to do these screencast? i'm looking for a tool that does print the keypress.

thanx

revelt commented 8 years ago

@sebest Screenflick for Mac. Really good.

jasonstolaruk commented 8 years ago

Does anyone know if/when this bug will be fixed? Setting a bookmark and later finding that I cannot navigate to it is a real bummer and it significantly affects my productivity. I'm considering switching to a different editor. Or is there an alternative that provides similar functionality in Atom? Thanks.

revelt commented 8 years ago

@jasonstolaruk It's a core feature, plugins won't help.

Sublime Text strangely doesn't have this problem, just checked. In theory, if you ever work with large files, you need to keep Sublime Text on the side anyway since Atom is too slow. Personally I keep my snippets are on Dash, so I don't care which code editor to use; I use both Atom and Sublime, whichever annoys me less at that moment :)

winstliu commented 8 years ago

It's a core feature, plugins won't help.

This is incorrect as bookmarks is already a package. Nothing is stopping you from creating, say, bookmarks-plus that fixes this issue and maybe adds extra features as well (see markdown-preview-plus, autocomplete-plus (which eventually replaced the old autocomplete), vim-mode-plus, etc).

That being said this should be looked at in the coming days.

as-cii commented 8 years ago

Apologies for this regression and thank you all so much for the patience! 🙇

A fix has been merged into master and it will go out with the next stable and beta releases. 🚀

revelt commented 8 years ago

Awesome! 👍👍👍 🦄🦄🦄 🍻🍻🍻

revelt commented 8 years ago

@as-cii will this also fix #62?

as-cii commented 8 years ago

No, #71 addresses only the buggy behavior of jumping between bookmarks, which has been broken for a while now. A pull request for fixing #62 would be super appreciated though! ✨

revelt commented 7 years ago

I'm still having issues with jumping between bookmarks, using Mac Atom 1.12.7. On normal use F2 jumps only to bookmarks below and doesn't cycle, and Shift+F2 jumps to bookmarks above, but cycles too.

Ben3eeE commented 7 years ago

I believe the fix is only available in 1.13 which is currently in beta.

mradam1977 commented 7 years ago

Yeah, bookmarks don't work very well. I constantly have to work around the problem by pressing F2 to move to bookmarks that I can reach, toggling them off and on again, then I can reach the others (the ones I didn't even toggle).