Previously we were relying on getMarkers returning an ordered set of DisplayMarker objects. The order in which markers were returned, however, was based on when they were added rather than on where they were added, making jumping among bookmarks buggy and unreliable.
With this pull request we are fixing the problem and adding some regression tests to ensure it doesn't happen anymore in the future. Moreover, bookmarks.coffee has been rewritten in JavaScript and the bookmark jumping logic has been greatly simplified as well, allowing us to also get rid of underscore-plus.
nathansobo
commented
8 years ago
Fixes #69.
Previously we were relying on
getMarkersreturning an ordered set ofDisplayMarkerobjects. The order in which markers were returned, however, was based on when they were added rather than on where they were added, making jumping among bookmarks buggy and unreliable.With this pull request we are fixing the problem and adding some regression tests to ensure it doesn't happen anymore in the future. Moreover,
bookmarks.coffeehas been rewritten in JavaScript and the bookmark jumping logic has been greatly simplified as well, allowing us to also get rid ofunderscore-plus./cc: @atom/core