Shift + F2 should select text

rsese commented 6 years ago

From @alexandernst on November 30, 2017 10:37AM CDT - copied from atom/atom#16300

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Holding Shift while jumping to a bookmark doesn't select the text.

Steps to Reproduce

Open any file with text/code inside
Go to any line and create a bookmark
Now go a few lines below the bookmark
Press and hold Shift and hit F2

Expected behavior: All the lines between where the cursor was the momento I pressed F2 and where the bookmark is should be selected.

Actual behavior: The cursor moved to the bookmark but the text wasn't selected.

Reproduces how often: 100%

Versions

Any version.

rsese commented 6 years ago

From @rsese on November 30, 6:00PM CDT

Thanks @alexandernst 👍 Since https://github.com/atom/bookmarks/pull/91 was added, it looks like this works in the case where there's a bookmark below where your cursor is:

'atom-text-editor':
  'shift-f2': 'bookmarks:select-to-next-bookmark'

But not the case you described above where the next bookmark wraps past the end of the file. I think we should maybe move this to https://github.com/atom/bookmarks? I can do that later tonight if you don't get to it.

rsese commented 6 years ago

Going to tentatively mark as a bug because if you have a single bookmark in the middle of a file and your cursor is below that bookmark, if you then run Bookmarks: Jump to Next Bookmark, that command will wrap past the end of the file. Seems like Bookmarks: Select to Next Bookmark would do the same?

Note that Bookmarks: Select to Next Bookmark will be available in 1.24 I believe.

atom / bookmarks