search

atom / bracket-matcher

Jump to brackets
MIT License
142 stars 98 forks source link

Use keymap instead of _.adviseBefore editor, 'insertText' #22

Open giorgian opened 10 years ago

giorgian commented 10 years ago

I was looking for a fix to #21, but noticed that the bulk of the work is done in a callback to _.adviseBefore.

Since only a few keys (brackets and quotes) are of actual interest, shouldn't this be addressed with keymaps?

kevinsawicki commented 10 years ago

This wasn't possible before because of the way keybindings were aborted, this has now been fixed via https://github.com/atom/atom-keymap/commit/b14ef2c1b39249b6832729f0596550a7f1b711b3 so this could now work, thanks for bringing it up.