search

atom / bracket-matcher

Jump to brackets
MIT License
142 stars 98 forks source link

[Notify] Clash in standard key-binding ( Ctrl + ] ) #326

Open ghost opened 6 years ago

ghost commented 6 years ago

Hello. May this message find you well.

Description

The standard keybinding used by this package clashes with the one used by the package handling indenting.

'atom-workspace atom-text-editor:not([mini])':
  'ctrl-]': 'editor:indent-selected-rows'

  'atom-text-editor':
    'ctrl-]': 'bracket-matcher:remove-brackets-from-selection'

Steps to Reproduce

  1. Open a text editor page
  2. Open the keybinding resolver Ctrl + .
  3. Press Ctrl + ]
  4. Read the result from the bottom dialog

This is the case for all OS on recent Atom versions (now: V1.21).

Expected behaviour

The keybindings of Core Packages should not clash. The indent package has a matching binding Ctrl + [. Luckily the indent package takes priority at the moment.

Recommendation

Options:

  1. Change the Ctrl + ] keybinding.
  2. Do not have a standard keybinding for bracket-matcher:remove-brackets-from-selection

Atom V1.21.1 on Windows7