atom / bracket-matcher

Jump to brackets
MIT License
142 stars 98 forks source link

Uncaught TypeError: Cannot read property 'start' of undefined #380

Closed MartinGuindon closed 5 years ago

MartinGuindon commented 5 years ago

Prerequisites

[Enter steps to reproduce:]

  1. Press Ctrl-M or go to Packages -> Bracket Matcher -> Go to Matching Bracket
  2. The error will appear, regardless, even in safe mode, regardless of the type of file or the content of the file being edited.

Atom: 1.34.0 x64 Electron: 2.0.16 OS: Mac OS X 10.14.3 Thrown From: Atom Core

Stack Trace

Uncaught TypeError: Cannot read property 'start' of undefined

At /Applications/Atom.app/Contents/Resources/app/static/<embedded>:14

TypeError: Cannot read property 'start' of undefined
    at TagFinder.isTagRange (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:508922)
    at TagFinder.findEnclosingTags (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:510789)
    at BracketMatcherView.gotoPrecedingStartBracket (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:665488)
    at BracketMatcherView.goToMatchingBracket (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:664094)
    at HTMLElement.BracketMatcherView.subscriptions.add.atom.commands.add (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:656178)
    at CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:350017)
    at KeymapManager.t.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1212945)
    at KeymapManager.t.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1209079)
    at WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:285196)

Commands

     -0:05.5.0 bracket-matcher:go-to-matching-bracket (input.hidden-input)

Non-Core Packages

rsese commented 5 years ago

Thanks for the report! Reproduced in 1.34.0 with macOS 10.12.6 - looks like 1.33.1 is the first version I see the error, not sure if it's related but https://github.com/atom/bracket-matcher/pull/377 was part of that release.