atom / bracket-matcher

Jump to brackets
MIT License
142 stars 98 forks source link

Add German single and double quotes #385

Closed getreu closed 5 years ago

getreu commented 5 years ago

Requirements

Description of the Change

Add German single and double quotes. See also Anführungszeichen – Wikipedia

Alternate Designs

void

Benefits

It enables German users to typeset German smart quotes.

Possible Drawbacks

none

Applicable Issues

none

rsese commented 5 years ago

Thanks for the contribution @getreu! To clarify, the setting I mentioned in https://github.com/atom/atom/issues/19424 was added in particular so people can customize the matched pairs however they'd like (e.g. see the discussion in https://github.com/atom/bracket-matcher/issues/121) and we won't need to change the defaults. Additionally, we're generally not changing defaults across Atom unless necessary and especially when Atom can be customized to get the same effect.

So for these reasons we're not going to accept this change, but we do thank you again for the contribution :bow:

getreu commented 5 years ago

I firmly disagree with your refusal:

This is not a customization matter or a matter of personal taste concerning default values!

This is about (German) localization. By refusing the German quotes that come with this PR, you keep Atom unusable for high quality typesetting in German language.

This is a general policy issue, I will put up for discussion.

Arcanemagus commented 5 years ago

Unfortunately Atom currently is not setup for localization, the best issue to follow for that is probably https://github.com/atom/atom/issues/3103. As mentioned in that issue a community package (atom-i18n) exists that translates a lot of the interface... it's entirely possible for that package to change the settings mentioned by @rsese to enhance the default values with the additional characters you are talking about when Deutsch (de) is selected as the language.

Note that your proposed change would be incorrect in other languages, which is why we can't update the default values to include that.