atom / chocolatey

chocolatey installer for Atom
MIT License
12 stars 17 forks source link

Multiple admin prompts appear during installation #30

Closed 50Wliu closed 10 years ago

50Wliu commented 10 years ago
'Atom' explorer menu item has been created
'Atom' explorer menu item has been created
'Atom' explorer menu item has been created

Required me to open Powershell as Administrator 3 times. Seems to be caused by https://github.com/atom/chocolatey/commit/00d2eb0901190c1c84c235de0cedd9512616922f?

kevinsawicki commented 10 years ago

@bradgearon can you take a look at this?

bradgearon commented 10 years ago

Does it actually create "multiple" explorer items? Or does it just pop three of those windows?

@kevinsawicki gladly

50Wliu commented 10 years ago

image

bradgearon commented 10 years ago

OK so it only creates one? This isn't an issue then, right? Or are the three admin prompts annoying?

50Wliu commented 10 years ago

Pretty annoying, yeah :P.

bradgearon commented 10 years ago

Thanks for identifying this then, I'll fix it!

bradgearon commented 10 years ago

try that please @50Wliu I changed the shortcut creation function to return a string so all the commands can be ran at once

50Wliu commented 10 years ago

Fixed, thanks :smile:.