search

atom / chocolatey

chocolatey installer for Atom
MIT License
12 stars 17 forks source link

Install installer via Chocolatey package #35

Closed kevinsawicki closed 9 years ago

kevinsawicki commented 9 years ago

Shoutout to @jongalloway for the tips here.

Waiting on https://github.com/Squirrel/Squirrel.Windows/issues/161 before merging this.

Closes https://github.com/atom/atom/issues/4526

gep13 commented 9 years ago

Hey,

Can I suggest that you also add the valid exit codes that your exe supports? If Chocolatey sees anything other than 0, and it isn't listed as a valid exit code, Chocolatey will throw an exception, even if the package installed correctly. i.e. if your exe returns a 3010 (Success Pending Reboot) Chocolatey will throw an exception if this isn't in the valid exit codes array.

Cheers

Gary

kevinsawicki commented 9 years ago

@gep13 Thanks for the tip, 0 is the only succesful exit code for the installer.

gep13 commented 9 years ago

Okay dokay :-)

Sent from my Windows Phone

From: Kevin Sawickimailto:notifications@github.com Sent: ‎11/‎12/‎2014 21:08 To: atom/chocolateymailto:chocolatey@noreply.github.com Cc: Gary Ewan Parkmailto:gep13@gep13.co.uk Subject: Re: [chocolatey] Install installer via Chocolatey package (#35)

@gep13 Thanks for the tip, 0 is the only succesful exit code for the installer.

Reply to this email directly or view it on GitHub: https://github.com/atom/chocolatey/pull/35#issuecomment-66689081

gep13 commented 9 years ago

@kevinsawicki sweet! Thanks for getting this pulled in :+1: