search

atom / command-palette

Command Palette in Atom
MIT License
116 stars 56 forks source link

Command palette incorrectly shows explicitly disabled keybindings #29

Open caleb531 opened 9 years ago

caleb531 commented 9 years ago

I've recently been tweaking my Atom keymap to unset a number of keybindings in favor of keybindings which suit my platform (i.e. cmd instead of ctrl, because I'm running OS X).

However, I noticed that even though I unset a particular keybinding, the keybinding still displays within the command palette for the command to which it was originally bound.

For example, I add the following lines to my keymap:

'.platform-darwin atom-workspace atom-text-editor':
    'shift-cmd-L': 'grammar-selector:show'
    'ctrl-shift-L': 'unset!'

As expected, the new keybinding triggers the grammar selector, and the old keybinding no longer triggers such. However, the old keybinding remains visible (alongside the new one) within the command palette.

Duplicate keybindings in command palette

I have every reason to believe that this is a bug, and because its effect can be misleading, I thought I should submit an issue for it.

Caleb

2alin commented 6 years ago

Any solution to this? I would like command palette to show my custom keymaps instead of permanently shows the default ones that I had unset already.

rsese commented 6 years ago

The issue is still open and there's no update/fix as far as I know - I'll mention this one to the team but we can't make any promises about if or when someone can investigate. But we're definitely open to looking at well-written pull requests.