atom / deprecation-cop

Shows a list of deprecated calls
MIT License
12 stars 19 forks source link

key binding conflict between php-beautifier, your deprecation-cop & 3 other packages, causes Dev Tools console to come up when invoking Settings #1

Closed faddah closed 10 years ago

faddah commented 10 years ago

hello,

i have found a key binding conflict between your php-beautifier package, your deprecation-cop package, and three other atom editor (ver. 0.94.0) packages, all sharing the same ctrl-alt-o (ctrl-option-o on Mac OS X) key binding.

your deprecation-cop package doesn't conflict with anything else when run without php-beautifier enabled. however, when php-beautifier is then enabled, it causes, when bringing up the Settings view tab/pane (cmd-,) in the atom editor, the Dev Tools console (usually invoked with cmd-alt-i) in the lower third of the atom editor window, when you haven't requested the Dev Tools console to come up.

when i turned php-beautifier from disabled to enabled and restarted Atom, i was able to reproduce the problem of bring up the Atom Dev Tools console when simply trying to open the Settings view tab/pane.

the reason this is happening, i believe, is because it shares the same key binding, ctrl-option-o, or ctrl-alt-o on non-Apple-Mac keyboards, as the following four packages i'm also running —

atom-git-show (https://github.com/fundon/atom-git-show) atom-javascript-snippets (https://github.com/zenorocha/atom-javascript-snippets) autoclose-html (https://github.com/mattberkowitz/autoclose-html) php-beautifier (https://github.com/sdwood/php-beautifier/)

your deprecation-cop package and all these, along with php-beautifier, share the same ctrl-alt-o key binding. yours with the other three co-exist just fine with that same binding (save the fact that the key binding doesn't work because of the conflict, you have to invoke your package by the Command Palette, cmd-shift-p), but the moment you enable php-beautifier and restart Atom 0.94.0, then try and bring up the Settings tab/pane, you get, suddenly, the Dev Tools console coming up in the bottom third of the Atom Editor window when you never asked for it.

i found this, after seeing php-beautifier was causing the issue, by using the keybinding-resolver package, which showed me all the packages sharing the same ctrl-alt-o key binding.

i thought you would want to know about this, contact the other package developers, and try and resolve this, perhaps by one or more of you choosing another key binding to invoke your deprecation-cop package.

i am also filing issues with these other developers and have also notified atom core support of this issue.

best,

— faddah wolf portland, oregon, u.s.a.

kevinsawicki commented 10 years ago

Can you include the error the shows in the dev tools?

kevinsawicki commented 10 years ago

I'm going to close this out, keybinding conflicts are inevitable with enough packages installed, if you provide the error you saw I'd be more than happy to reopen and fix it though.