This fixes https://github.com/atom/deprecation-cop/issues/47. As far as I can tell, the problem here was that the variable deprecations from the outer loop was used in the inner loop, and was getting overwritten. This problem was introduced here -- previously the outer loop didn't use a deprecations variable, it just re-fetched the deprecations in every iteration of the loop. Really sorry for not catching this before.
This PR fixes the problem by changing the variable's name in the inner loop so that there's no conflict. We could also use the same approach as before. This just seemed a bit cleaner.
Before:
After (correctly lists deprecations in styles.less):
kevinsawicki
commented
9 years ago
This fixes https://github.com/atom/deprecation-cop/issues/47. As far as I can tell, the problem here was that the variable
deprecationsfrom the outer loop was used in the inner loop, and was getting overwritten. This problem was introduced here -- previously the outer loop didn't use adeprecationsvariable, it just re-fetched the deprecations in every iteration of the loop. Really sorry for not catching this before.This PR fixes the problem by changing the variable's name in the inner loop so that there's no conflict. We could also use the same approach as before. This just seemed a bit cleaner.
Before:
After (correctly lists deprecations in styles.less):
cc @kevinsawicki for :eyes: