search

atom / deprecation-cop

Shows a list of deprecated calls
MIT License
12 stars 19 forks source link

Not catching a deprecated API call in 0.52.0 #52

Closed dead-claudia closed 9 years ago

dead-claudia commented 9 years ago

atom-html-preview fails to load, but when I ran Atom with --include-deprecated-apis, Deprecation Cop showed absolutely nothing. I can't tell exactly what API this fails to find, but it's near impossible to fix the broken package without knowing what broke.

Without flag: without flag

With flag: with flag

izuzak commented 9 years ago

@impinball Thanks for the report -- I don't see anything wrong with that package either.

@benogle @kevinsawicki can you take a look? :pray: I think this might be a false positive in the list of deprecated packages. :clipboard:

benogle commented 9 years ago

The deprecation may not be hit on startup, but this is what it's reporting:

Accessing PaneView via $::view() is deprecated. Use the raw DOM node or underlying model object instead.

https://gist.github.com/benogle/6d09e295c84b717ef9b4

izuzak commented 9 years ago

Thanks, @benogle. I think I see the deprecation from that repo now. I tried triggering that code path but wasn't able to (possibly another problem in the package), so that explains why I didn't notice the problem when I tried using the package.

I hope that helps, @impinball. :point_up: