search

atom / deprecation-cop

Shows a list of deprecated calls
MIT License
12 stars 19 forks source link

Fixed failing spec on Windows #57

Closed kubetz closed 9 years ago

kubetz commented 9 years ago

DeprecationCopView spec is failing on Windows because paths are using hardcoded / as a separator while the check for paths to node_modules is working with path.sep. This is causing package1 to be selected as an package name instead of expected package2.

I also removed commas from stack as some were missing anyway and packagePathsByPackageName is not using any.

I used Node's path.normalize that should make sure returned path is normalized for the used operating system.

kevinsawicki commented 9 years ago

Thanks for fixing these :green_heart: