search

atom / encoding-selector

Pick an encoding for the current editor
MIT License
21 stars 26 forks source link

Uncaught (in promise) Error: Encoding not recognized: 'windows866' (searched as: 'windows866') #36

Closed idfumg closed 8 years ago

idfumg commented 8 years ago

Good day! I have the same problem as in the #23. I saw you fixed it in the c664409 in encoding-selector. And this working now for me if I select particular encoding for a separate file. But in the atom default setting I still have to choose 'windows866' encoding. And it cause of the same error when opening a file in the 'iconv' module. I have a vanilla atom editor with only preinstalled packages v.1.9.9 (in v.1.10.0-beta6 the same behaviour). May be this enum value in the atom defaults have to be changed to 'cp866' too?

winstliu commented 8 years ago

Cannot confirm. This works for me on 1.11.0-dev-a0f7669.

damieng commented 8 years ago

Confirmed repro here on Windows 10.