atom / encoding-selector

Pick an encoding for the current editor
MIT License
21 stars 26 forks source link

Restore ability to display encoding for pending text editor panes #49

Closed jasonrudolph closed 7 years ago

jasonrudolph commented 7 years ago

Description of the Change

As one part of resolving https://github.com/atom/status-bar/issues/194, this pull request updates this package to take advantage of the new Workspace::observeActiveTextEditor(callback) API being introduced in https://github.com/atom/atom/pull/14695.

Alternate Designs

See https://github.com/atom/atom/pull/14695

Benefits

The package will regain the ability to display the file encoding for pending text editor panes.

Possible Drawbacks

See https://github.com/atom/atom/pull/14695

Applicable Issues

Demo

Before

encoding-selector-before

After

encoding-selector-after