Unflake a test - Githubissues

winstliu commented 7 years ago

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

This approach works, but I'm not sure if it's the best solution, because I don't know what atom.views.updateDocument is for. Removing that function seemed to fix the flake as well.

Alternate Designs

See above.

Benefits

One less flake.

Applicable Issues

Fixes #54

winstliu commented 7 years ago

Closing in favor of #56.

maxbrunsfeld commented 7 years ago

Oh, sorry for not seeing this @50Wliu 😬 ; this would have been fine too.

In any case, I did a little extra work to get rid of the polling and use await, so it wasn't just a total repeat of your work.

winstliu commented 7 years ago

Yeah your solution is much cleaner, and it converts things to JS :sparkles:.

atom / encoding-selector

Unflake a test #55

Requirements

Description of the Change

Alternate Designs

Benefits

Applicable Issues