In investigating https://github.com/atom/atom/issues/19554, we discovered that every single test that was awaiting the heightInvalidationPromise on its view still passes if we don't await that promise. Since we're concerned that these awaits are the source of timeouts like the one in the linked issue, we decided to completely remove that logic from all tests.
We also took the opportunity to replace element-resize-detector with the native ResizeObserver API which was introduced after the code in this package was written.
Hopefully this addresses all of the remaining flakiness in our tests for this package.
:pear:'d with @as-cii
Fixes https://github.com/atom/atom/issues/19554
In investigating https://github.com/atom/atom/issues/19554, we discovered that every single test that was awaiting the
heightInvalidationPromiseon its view still passes if we don't await that promise. Since we're concerned that theseawaits are the source of timeouts like the one in the linked issue, we decided to completely remove that logic from all tests.We also took the opportunity to replace
element-resize-detectorwith the nativeResizeObserverAPI which was introduced after the code in this package was written.Hopefully this addresses all of the remaining flakiness in our tests for this package.