atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 196 forks source link

Atom 1.40.1 [Linux]: find in buffer does not work #1099

Closed lierdakil closed 5 years ago

lierdakil commented 5 years ago

Prerequisites

Description

Find of find-and-replace Atom core package does not search in current buffer in Atom 1.40.1. Find-in-project still works. Everything is fine in Atom 1.39.1.

Steps to Reproduce

  1. Open a file in Atom
  2. Run find-and-replace:show command
  3. Try searching for something

Expected behavior:

Find and replace finds text present in the file

Actual behavior:

Find and replace never finds anything

Reproduces how often:

100%

Versions

Atom : 1.40.1 Electron: 3.1.10 Chrome : 66.0.3359.181 Node : 10.2.0

apm 2.4.3 npm 6.2.0 node 10.2.1 x64 atom 1.40.1 python 2.7.16 git 2.22.1

Additional Information

A video showing the issue https://youtu.be/IdpzJDsIyos

rsese commented 5 years ago

Thanks for the report! I was unable to reproduce with 1.40.1 on ubuntu 19.04 just now - have you already tried temporarily resetting to factory defaults to see if that makes any difference?

Also what distro are you using?

lierdakil commented 5 years ago

Hi. Sorry for wasting your time, I've spent all of today trying to debug this, and basically this gets down to some sort of mismatch in the Node's native module interface. In this particular case, NativeBuffer.findAndMarkAllSync was always returning undefined. Apparently this was caused by a dirty build environment. That is to say, after I've remembered to run script/clean before rebuilding, I couldn't reproduce the issue anymore. Just finished with this. Sorry again for the bogus report.

rsese commented 5 years ago

Ahh ok no problem, forgot to ask if you might be building Atom too - thanks for letting us know what the issue was and for closing https://github.com/atom/atom/issues/19918 :+1: