search

atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 219 forks source link

Add option to save search resulst from being overwrittenby next search #1109

Closed Indieberrie closed 4 years ago

Indieberrie commented 4 years ago

Description of the Change

Every project search, overrides last search's results. This PR adds button to results tab, that when clicked, saves that tab, so it won't be overwritten by next search. Next search will open results in new tab (that can be overwritten, unless button in that one is clicked). After clicking button gets disabled

image image

Alternate Designs

Main focus is to have multiple results open at the same time. Other approach was to put this button, but it was easy to lose track of what tabs would stay open, and what overwritten. image

Benefits

Easier code navigation

Possible Drawbacks

Applicable Issues

https://github.com/atom/find-and-replace/issues/360

darangi commented 4 years ago

Thanks for the contribution 🙇 @Indieberrie