atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 219 forks source link

Error message from `atom.workspace.scan()` using ripgrep can take the whole screen #1120

Open ariasuni opened 4 years ago

ariasuni commented 4 years ago

Prerequisites

Description

Screenshot_20200417_144552

Steps to Reproduce

Make a lot of symbolic links to non-exist files under Linux in the folder Atom is currently opened in.

Expected behavior:

Size of the error message is limited so that an unusual amount of text error doesn’t make the find-and-replace unusable.

Actual behavior:

Size of the error message is taking the whole screen, we can’t see the fields or the results anymore.

Reproduces how often:

All the time.

Versions

Atom : 1.45.0 Electron: 4.2.12 Chrome : 69.0.3497.128 Node : 10.11.0 apm 2.4.5 npm 6.14.4 node 13.13.0 x64 atom 1.45.0 python 3.8.2 git 2.26.1

Additional Information

I bisected Firefox and the build process happens to use symbolic links for a lot of resources. But they’re not cleaned up and I didn’t knew or care about it until it messed up Atom. Just developing and updating Firefox source code means that it will happens and become worse as files are renamed in the source code.

Rigrep doesn’t care if there are dead symbolic links in the folders it searches in and neither should Atom.

Linked issue: atom/atom#20637