search

atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 196 forks source link

Find whole word in PHP code unable to match variables with a preceding $ sign #1122

Closed aurovrata closed 4 years ago

aurovrata commented 4 years ago

the search is able to find variables start with the word, for example searching for $valid will find

$valid $validation (highlights only $valid part of the word) $validted (highlights only `$valid part of the word)

however, when toggling the 'whole word` option, it finds no match.

I have to use the 'regex' mode and search for '\$valid ' with a space after it.

Arcanemagus commented 4 years ago

Thanks for taking the time to contribute!

We noticed that this is a duplicate of https://github.com/atom/find-and-replace/issues/1121. You may want to subscribe there for updates.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.

For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

aurovrata commented 4 years ago

odd that it got submitted twice, and the numbers are concurrent, so must have something wrong with the submission process.