Find and replace all momentarily reports incorrect number of results found

[finnbear]

Prerequisites

• [x] Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

After using the find and replace all option, the number of results found is reset to 0. This is sometimes appropriate but not always.

Steps to Reproduce

1.In any file, type a string like "abcdabcd"

2. Find and replace "abcd" with "abcdabcdabcd" (atom shows 2 results found before clicking replace)
3. Watch the number of results found right after clicking the find and replace button

Expected behavior:

Text in the file is now: abcdabcdabcdabcdabcdabcd Number of results found is: 6

Actual behavior:

Text in the file is now: abcdabcdabcdabcdabcdabcd Number of results found is: 0 Number of results found after a second or two: 6

Proposed solution:

Instead of setting the number of results found to 0, multiply the previous number of results found by the number of times the string to find appears in the string to replace.

Reproduces how often:

100%

Versions

1.46.0 Ubuntu 19.04