atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 196 forks source link

Add devtools catch #1137

Closed Aerijo closed 4 years ago

Aerijo commented 4 years ago

Requirements

Description of the Change

Reduces flaky test failures on the main Atom repo CI. The summary is that an uncaught exception is triggering dev tools, which breaks tests. See https://github.com/atom/atom/pull/21335 for more.

Alternate Designs

Fixing the root of the problem. But that's a lot more difficult, seeing as the cause hasn't been completely determined yet. Investigations are welcome!

Benefits

Reduced false CI failures on main repo PRs

Possible Drawbacks

This is only masking the deeper issue, so isn't a fix and should not be treated as such.

Applicable Issues

None. It does not completely resolve any issues.