atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 219 forks source link

Find and replace does not work for whole directories #1149

Closed MeerKatDev closed 3 years ago

MeerKatDev commented 3 years ago

Prerequisites

Description

The find and replace doesn't work anymore

Steps to Reproduce

Open search tab, try to search something in a subdirectory

Expected behavior:

To find text

Finds nothing at all, and searches no path too

always

Versions

atom version 1.54.0 on macOS Big Sur v11.1

Additional Information

Not much, just that. No packages interacting with it. Does the same in safe mode

Screenshot 2021-03-13 at 11 14 54
ThatXliner commented 3 years ago

I'm pretty sure it asks for a directory, not a file glob

EDIT: there's a possibility that it juts didn't match anything. Or that your file glob isn't right. I'll try to reproduce later

ThatXliner commented 3 years ago

Yeah so I'm pretty sure Atom thinks you're searching for the directory named /some/random/thing/so/long/*.php instead of a glob... probably a bug.

You should probably report this in the atom/find-and-replace package

sadick254 commented 3 years ago

@MeerKatDev Find and replace works as expected. The directory/subdirectory search works with paths relative to the project opened. A good subdirectory search in your case would be src/*.php which works as you would expect.

@ThatXliner this is definitely not a bug but expected behaviour for the find and replace package.