atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 196 forks source link

Double clicking on result list leads to Uncaught TypeError #650

Open Yomi0 opened 8 years ago

Yomi0 commented 8 years ago
  1. Search for a string that only occurs in one file of a project.
  2. Double click on the result list with file icon. (where the mouse is in this screenshot) screenshot_2016-01-24_00-14-48
  3. Error occurs.

Atom Version: 1.6.0-dev-f914d18 System: "Arch Linux" Thrown From: find-and-replace package, v0.196.0

Stack Trace

Uncaught TypeError: _ref3.then is not a function

At /usr/local/share/atom/resources/app.asar/node_modules/find-and-replace/lib/project/results-view.js:52

TypeError: _ref3.then is not a function
    at space-pen-li.<anonymous> (/usr/local/share/atom/resources/app.asar/node_modules/find-and-replace/lib/project/results-view.js:52:23)
    at space-pen-ol.jQuery.event.dispatch (/usr/local/share/atom/resources/app.asar/node_modules/jquery/dist/jquery.js:4435:9)
    at space-pen-ol.elemData.handle (/usr/local/share/atom/resources/app.asar/node_modules/jquery/dist/jquery.js:4121:28)

Commands

     -0:28.4.0 project-find:show (atom-text-editor.editor.is-focused)
     -0:25.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "autoHideMenuBar": true,
    "disabledPackages": [
      "whitespace",
      "language-clojure",
      "language-coffee-script",
      "language-csharp",
      "language-go",
      "language-hyperlink",
      "language-java",
      "language-less",
      "language-mustache",
      "language-objective-c",
      "language-javascript",
      "language-json",
      "language-ruby",
      "language-ruby-on-rails",
      "language-sass",
      "language-sql",
      "language-xml",
      "language-yaml"
    ],
    "openEmptyEditorOnStart": false,
    "themes": [
      "one-dark-ui",
      "solarized-dark-syntax"
    ]
  }
}

Installed Packages

# User
build, v0.52.0

# Dev
No dev packages
lee-dohm commented 8 years ago

I reproduced this using Atom v1.6.0-dev-62c1f6a on Mac OS X 10.11.2 by double-clicking on the filename when the search results were expanded:

uncaught-error-repro