search

atom / find-and-replace

Find and replace in a single buffer and in the project
MIT License
242 stars 219 forks source link

After "searching all", "replacing all" is impossible with ctrl + enter #666

Open sftd opened 8 years ago

sftd commented 8 years ago

If you are doing "global search" then no matter if you commit it using "enter" or find button window with search results gets focus. This makes ctrl + enter shortcut unusable in this case. I am aware that it is more logical in most cases for window with search results get focus (instead of leaving it on search window).

But it would be nice if even after changing focus "ctrl + enter" shortcut would work for "replacing all" search results.

lee-dohm commented 8 years ago

So you want Ctrl+Enter to act as "Replace All" if there are active search highlights ... even if the focus is on the editor window, not the find-and-replace view?

sftd commented 8 years ago

Yes, I think it can be useful.

In situation I encountered recently I had to make a lot of global replacement and such a behavior would greatly speed up the process.

lee-dohm commented 8 years ago

What if you disabled "Focus Editor After Search" in the find-and-replace package settings?

screen shot 2016-02-20 at 12 20 52 pm

I feel like what you're requesting could be useful for certain workflows perhaps. I'm just not certain that it isn't covered already.

sftd commented 8 years ago

"Focus Editor After Search" seems to work only when searching inside file. When doing global search it is ignored (Atom 1.6.0-beta5).

But that would wokr for me. Though for example for my workflow checkbox in search panel would be easier to use.

oxk4r01 commented 7 years ago

sftd is rigth. "Focus Editor After Search" does not work for me too. I have to press tab key three times for Ctrl+Enter to work