atom / flight-manual.atom.io

📖 Documentation for Atom, generated by nanoc, hosted by GitHub Pages
https://flight-manual.atom.io
Other
640 stars 1.54k forks source link

Enhance build to process API JSON files for Atom 1.0.0 and newer #537

Closed jasonrudolph closed 5 years ago

jasonrudolph commented 5 years ago

This pull request targets the api-docs branch. (That branch is currently a work in progress. We anticipate opening a pull request for that branch soon.)

jasonrudolph commented 5 years ago

:wave: @lee-dohm: Here's what I'm working on for the API docs migration so far. If you see anything in here that seems like it's going in a different direction than what you had in mind, please let me know. :bow:

lee-dohm commented 5 years ago

Sounds like the right approach to me! 👍

jasonrudolph commented 5 years ago

:wave: @lee-dohm: I think this is ready for review now.

Note that the build currently fails when attempting to verify external links, but I anticipate us fixing that issue before we merge these changes into master. (This pull request targets the api-docs branch, so merging this pull request will not merge these changes to the master branch.)

jasonrudolph commented 5 years ago

:wave: @lee-dohm: I'm gonna go ahead and merge this branch, so that @as-cii and I can get started on the next steps. However, if you notice anything that you'd like to see changed, just let me know, and I'll be sure to take a look.