atom / flight-manual.atom.io

šŸ“– Documentation for Atom, generated by nanoc, hosted by GitHub Pages
https://flight-manual.atom.io
Other
640 stars 1.54k forks source link

Add Atom's API docs to the Flight Manual #541

Closed jasonrudolph closed 5 years ago

jasonrudolph commented 5 years ago

This pull request aims to bring the Atom API reference docs into the Flight Manual. These docs currently reside at https://atom.io/docs/api, and we'd like for them to move them into this repository so that all of Atom's docs are consolidated in a single place.

TODO

/cc @lee-dohm @as-cii

jasonrudolph commented 5 years ago
  • [ ] When navigating to the root URL (/api), show the docs for the current stable version

@lee-dohm @as-cii: I've just about got this ā˜ļø working locally. I've gotta head out for dinner, but I'm hoping to get this pushed up tomorrow morning.

lee-dohm commented 5 years ago

I got this working for both the main table of contents at / and in the sidebar of each page. I sandwiched the API docs between the chapters and the appendices. I fiddled around with the memoization to speed things up and it's pretty quick for going through 140+ versions of API docs.

Right now though, the class links all refer to /api/latest/ClassName/index.html so either we'll need to fiddle with the routes rules in Rules or, if that won't work, I can quickly redo it to put the latest version number in the URL.

Oh, and the links pointing to invalid references is why the build is failing šŸ˜Š

lee-dohm commented 5 years ago

Updated the links to use a hardcoded version.

jasonrudolph commented 5 years ago

I've compared the current content at https://atom.io/docs/api to the content rendered by this branch, and I've updated the issue body to list the differences that I've noticed so far.

jasonrudolph commented 5 years ago

@lee-dohm: I think this is looking pretty good now. Would you mind trying out these changes to see if there's anything that's essential to change before we ship?

Note: Given the size of this diff and how long this branch has been in progress, I think we should lean heavily toward getting to a reasonable production "v1" of these changes as soon as possible and deferring any enhancements to separate pull requests. šŸ˜‡

lee-dohm commented 5 years ago

I'll take a look at this first thing in my morning tomorrow. Thanks so much for all the work driving this forward @jasonrudolph and @as-cii šŸ™‡ I agree that a reasonable v1 is the appropriate action here.

lee-dohm commented 5 years ago

This looks great! I've marked the PR as ready for review while I dig deeper into it.

calebmeyer commented 5 years ago

From taking a quick look at the website:

Edit: I'm also in favor of a quick v1. These are definitely not show stoppers. If you'd like, I can open issues for them.

jasonrudolph commented 5 years ago

Thanks for the review! I'm gonna roll this out now.

Despite all our testing and code review, I anticipate us discovering at least some issues in real-world use due to the sheer magnitude of this change. To minimize the impact, we'll keep an eye on issues filed over the next few days, and we'll try to respond as quickly as possible to any problems that come up.