search

atom / fuzzy-finder

Find and open files quickly
MIT License
275 stars 138 forks source link

Find File matches single characters (too many matches) #261

Open arlowhite opened 7 years ago

arlowhite commented 7 years ago

fuzzy-finder 1.4.0

Prerequisites

Find File search matches single characters, resulting in too many matches.

Low priority because fuzzy-finder sorts better matches higher on list. But I still thought I'd send you this screenshot.

Steps to Reproduce

  1. Find > Find File
  2. enter search text

Expected behavior:

File paths should only match if at least two adjacent query characters match two adjacent path characters.

Alternate Rule: Only X single character matches are allowed in a result. (X could be configurable; I'd set it to 2 by default)

Actual behavior:

atomfilesearch

Possible issues with fix

The only problem I can think of, is if people have directories or files that are just one character. a/b.js

But with this fix, users could just type one more character to get a match: "a/" to see all files under the a directory. "b." to match the file.

However, with the Alternate Rule above (X=2), "ab" would match a/b.js

fohrums commented 7 years ago

+1 Fuzzy Finder needs a match-beginning/end search-results setting to make the search more flexible

First off, these key-terms matching is quite difficult to explain and the only way I could demonstrate it is through a mix of terminology that Atom uses and from another software I use that isn't related to Atom at all but serves as an example. So you're having trouble with your searches matching many way-too-spread-out results? If I understand correctly this is otherwise known as whole-word searches, right? My problem is Fuzzy Finder is not being able to search results from characters-appended or ending-characters.

Like how DoubleCommander does it, you can disable match beginning/ending so that way literally anything matches.

EXAMPLE (How DoubleCommander does it)

NOTE