fuzzy-finder doesn't withhold keyboard events that fire during re-index and panel opening

dwelle commented 7 years ago

Prerequisites

[x] Reproduced the problem in Safe Mode
[x] Checked that your issue isn't already filed

Description

Since 1.16.0 either the project reindexing perf drastically downgraded, or there's a regression (or both) that causes the text typed after user hits ctrl + p being added to editor instead of the fuzzy-finder panel, provided user starts to type before reindexing is done and panel opens.

AFAIK this never happened to me before and I always start to type well before the panel opens (waiting for and ensuring the panel is open before typing is really bad UX).

This causes major problems if one's not careful and the nonsense text goes through linting, CRs etc. (not that often -- but still causes major pain due to constant refactor, backtracking etc.)

Steps to Reproduce

open a project with moderate amount of files so that reindexing takes considerable time (0.5-1s+)
blur & refocus atom to ensure reindexing
ctrl + p and start typing right away

Expected behavior: should enqueue the keyboard events until the panel opens (or whatever other implem), and seamlessly paste whatever user typed before it opened

Actual behavior: the text that's typed before the panel opens is entered into file buffer

Reproduces how often: 100% (well, practically every time I fuzzy-search for file after de-focusing atom, which is nearly always)

Versions

atom 1.16.0, fuzzy-finder 1.5.0, win 7

atom / fuzzy-finder