Misleading caption displayed during line number entry

[jtagscherer]

Prerequisites

• [X] Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

When a user wants to jump to a line in the currently opened file, they can use the fuzzy finder to do so by entering a colon followed by the line number. If the line number becomes invalid after further input, the finder warns the user. This warning persists even if the user corrects their input, potentially misleading them. Confirming the dialog and jumping to the entered line number works regardless of the alert.

Steps to Reproduce

1. Start Atom and open an arbitrary file.
2. Press ⌘+T to open the fuzzy finder.
3. Enter a colon and a valid line number, for example :42. The dialog hints that this will make the editor jump to the corresponding line.
4. Make the entered line number invalid, for example by appending a non-numeric character to your input. The dialog changes its hint, making the user aware that their input is invalid.
5. Make the entered line number valid again, for example by deleting the non-numeric character.

Expected behavior: The dialog should return to displaying the previous hint about jumping to the entered line in the active editor.

Actual behavior: The dialog keeps displaying the alert until the search box is cleared, although the input is in fact valid.

Reproduces how often: Everytime.

Versions

Atom    : 1.32.0
Electron: 2.0.9
Chrome  : 61.0.3163.100
Node    : 8.9.3

apm  2.1.2
npm  6.2.0
node 8.9.3 x64
atom 1.32.0
python 3.6.4
git 2.17.2

OS: macOS Mojave (10.14)