search

atom / fuzzy-finder

Find and open files quickly
MIT License
274 stars 138 forks source link

Correctly update the caption during line number entry #359

Closed jtagscherer closed 5 years ago

jtagscherer commented 5 years ago

Description of the Change

As outlined in #358, the status message of the fuzzy finder did not update correctly while entering line numbers. This was due to an issue within the logic used to update the status message: The alert was not replaced by the standard message when the input became valid again because the previousQueryWasLineJump flag would stay true during the process, preventing the necessary block of code to be run.

The changes within this pull request fix this issue while simplifying the code in question a bit.

This is my first contribution to Atom, and I hope I did everything right. Do point me towards any mistakes I might have made though.

Alternate Designs

N/A

Benefits

The fuzzy finder always displays an appropriate status message when entering line numbers, no longer misleading users.

Possible Drawbacks

N/A

Applicable Issues

358

jtagscherer commented 5 years ago

I don't know why one of the tests in only one of the CI builds has failed. On my machine and on the Travis build all tests run successfully. In fact, the failing test does not seem to touch on what I've changed. Can a maintainer help me out with this one?

50Wliu commented 5 years ago

I've restarted the build and it looks good now.

jasonrudolph commented 5 years ago

I tried this change out locally and verified that it resolves the problem described in #358.

I reviewed the diff, and it looks like a solid improvement to me.

I made some minor tweaks to the test in https://github.com/atom/fuzzy-finder/compare/94f251281297211fea91c4c6149d56567be8fefc...d53f278abff1887e80ab33fabe7e806579150cc1.

Thanks for this contribution, @jtagscherer! :bow:

jtagscherer commented 5 years ago

Happy to help! Thank you for your improvements to my PR, @jasonrudolph.