search

atom / fuzzy-finder

Find and open files quickly
MIT License
274 stars 138 forks source link

Checking which paths are ignored by Git cripples path searching performance #361

Closed mattlyons0 closed 5 years ago

mattlyons0 commented 5 years ago

https://github.com/atom/fuzzy-finder/blob/59836e1a9ec39ec5c7a3ef305487f67f1f23388e/lib/load-paths-handler.js#L39

Disabling the line included above causes the searching of paths to go from 6000-7000ms to 2000-3000ms.

I am benchmarking by opening this project and the Linux Kernel in Atom. Although the Linux Kernel is an extreme case when considering #88 every improvement to path searching counts.

A proof of concept implementation with scandal seems to be able to drop the initial scanning time to 5000-6000ms and then 3000-4000ms for future searches.

50Wliu commented 5 years ago

I believe this has been improved substantially by #366 and will improve even further with #369 - please let me know if you think this issue should remain open.