Since https://github.com/atom/fuzzy-finder/pull/360, the fuzzy finder allows users to jump not only to lines within files but also to columns within lines by using a second colon. Since https://github.com/atom/fuzzy-finder/pull/359, the hint in the finder's caption is correctly updated while jumping to lines. I implemented both of these pull requests simultaneously, and since I had no control over when they were merged, I unfortunately could not include jumping to columns within the hints.
In consequence, the hint in the finder view erroneously considers input with two colons invalid. This creates a bad user experience by harming the discoverability of the feature of jumping to columns. Not only does the finder not hint at the feature, but it actively discourages users from using the feature by displaying an error message.
Steps to Reproduce
Open any file with some content
Open the fuzzy finder, e.g. by pressing CMD+P
Insert a line and column separated by colons, e.g. :4:2
Expected behavior:
When entering a line and a column, the finder should display an appropriate hint, e.g. "Jump to position in active editor". If the part before the second colon is invalid, it should display "Invalid line number". If the part after the second colon is invalid, it should display "Invalid column number".
Actual behavior:
The hint does not differentiate between jumping to lines and columns. Even worse, it displays an error message when trying to jump to a column, even though the input is technically valid.
Description
Since https://github.com/atom/fuzzy-finder/pull/360, the fuzzy finder allows users to jump not only to lines within files but also to columns within lines by using a second colon. Since https://github.com/atom/fuzzy-finder/pull/359, the hint in the finder's caption is correctly updated while jumping to lines. I implemented both of these pull requests simultaneously, and since I had no control over when they were merged, I unfortunately could not include jumping to columns within the hints.
In consequence, the hint in the finder view erroneously considers input with two colons invalid. This creates a bad user experience by harming the discoverability of the feature of jumping to columns. Not only does the finder not hint at the feature, but it actively discourages users from using the feature by displaying an error message.
Steps to Reproduce
:4:2Expected behavior:
When entering a line and a column, the finder should display an appropriate hint, e.g. "Jump to position in active editor". If the part before the second colon is invalid, it should display "Invalid line number". If the part after the second colon is invalid, it should display "Invalid column number".
Actual behavior:
The hint does not differentiate between jumping to lines and columns. Even worse, it displays an error message when trying to jump to a column, even though the input is technically valid.
Reproduces how often:
Always.
Versions
Atom Version:
APM Version:
Operating System:
macOS Mojave (10.14.2)