jtagscherer
commented
5 years ago Works great, thanks! 👍
I was actually just fixing this as well, and I pulled out the errorMessage and emptyMessage into variables that I set in the individual branches of the if statement. That way the readability of the code is improved a bit and I have to call this.selectListView.update only once. That may be an option to consider:
var emptyMessage = null
var errorMessage = null
if (/^:\d+:\d*\D/.test(query)) {
errorMessage = 'Invalid column number'
} else if (/^:\d+:/.test(query)) {
emptyMessage = 'Jump to line and column in active editor'
} else if (/^:\d*\D/.test(query)) {
errorMessage = 'Invalid line number'
} else {
emptyMessage = 'Jump to line in active editor'
}
this.selectListView.update({
items: [],
emptyMessage: emptyMessage,
errorMessage: errorMessage
})Oh, and a quick heads-up: You committed your package-lock.json, which you probably shouldn't.
rafeca
50Wliu
Requirements
Description of the Change
With #360, you can now specify a specific column when jumping to a line. The error reporting for invalid line numbers, however, was not updated to allow columns as well. This PR adds additional cases to the error handling such that it reports column errors correctly and does not inadvertently display "Invalid line number" when attempting to navigate to a column.
Alternate Designs
None.
Benefits
An incorrect error is removed and there is better discoverability of the feature.
Possible Drawbacks
None.
Applicable Issues
Fixes #363, /cc @jtagscherer