atom / fuzzy-finder

Find and open files quickly
MIT License
276 stars 138 forks source link

Do not call `setItems()` every time that the fuzzy finder is shown #373

Closed rafeca closed 5 years ago

rafeca commented 5 years ago

Description of the Change

This PR unblocks the work to use native-fuzzy to improve the filtering performance by mitigating one of its concerns.

Basically, before this PR the UI was blocked by the execution of the setItems() method every time the fuzzy finder was shown (and it delayed its appearance in the UI). This was not a big problem before because the setItems() method used to be quite fast, but with the addition of native-fuzzy we need to do more expensive things here (we need to serialize and pass the whole list of items to the native-fuzzy).

Alternate Designs

N/A

Benefits

Possible Drawbacks

N/A

Applicable Issues

https://github.com/atom/fuzzy-finder/issues/370