atom / fuzzy-finder

Find and open files quickly
MIT License
274 stars 138 forks source link

Show prompt to enable "fast mode" on large projects #376

Closed rafeca closed 5 years ago

rafeca commented 5 years ago

Context

Atom 1.37 will ship with two important performance improvements ([1] and [2]) on the fuzzy finder, both of them behind config flags and disabled by default (we want to minimize risks of breaking users' workflows by having both of them disabled for a version).

Under the hypothesis that not many people will enable these features if we don't do anything, we want to show a prompt to a subset of users so they can easily enable them and we can get some early data and potential issues before we enable the feature by default.

Constrains

These are the constrains that our solution will have:

Potential solution

Show a Notification to the user if the crawling process took more than e.g 5s and if the notification hadn't been shown before.

The notification should have clear call to action buttons that don't require the user to navigate to other parts of the application. Example of notification:

Screen Shot 2019-04-01 at 12 35 25

Metrics

In order to understand how successful is this notification, we can log the following data:

rafeca commented 5 years ago

I have been pairing with @jasonrudolph early today on this issue and we've pivoted quite a bit from the original idea and improved the whole solution for the prompt.

This is what the new prompt is going to look like (design not final):

Screen Shot 2019-04-03 at 19 54 49

I'm gonna send a WIP PR with the initial work that we and @jasonrudolph have started.

jasonrudolph commented 5 years ago

Now that https://github.com/atom/fuzzy-finder/pull/378 is merged, I think we can close this issue.

@rafeca: If this issue should remain, open please feel free to re-open it.