search

atom / fuzzy-finder

Find and open files quickly
MIT License
276 stars 138 forks source link

Return a promise instead of using waitsFor #377

Closed rafeca closed 5 years ago

rafeca commented 5 years ago

Sending this PR to check if it improves the flakiness reported in https://github.com/atom/atom/issues/19095

rafeca commented 5 years ago

I've built this PR 8 times already and each of them have finished successfully. If this fixes the timeout issue, I honestly do not know why, but I'm ok living with the mystery 😅

List of builds:

  1. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23563812
  2. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23564002
  3. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23564209
  4. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23564501
  5. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23577378
  6. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23579267
  7. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23579449
  8. https://ci.appveyor.com/project/Atom/fuzzy-finder/builds/23579588
jasonrudolph commented 5 years ago

I'm ok living with the mystery 😅

😆

This seems like it's worth shipping to me. The apparent reduction in flakiness feels promising. 🤞

rafeca commented 5 years ago

It seems like the builds on https://github.com/atom/fuzzy-finder/pull/378 have started passing consistently after merging this (they were quite flaky before).