Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
We could change fuzzy-native to accept an object that contains both the full path of the result (or an id) + the string to use for the matcher (as the standard fuzzy matcher does), but that would require sending a much bigger object to the native side which could slowdown thing (plus the change would be bigger and affect other repos).
Requirements
Description of the Change
This PR fixes https://github.com/atom/fuzzy-finder/issues/382 by adding any root that contains a filter result to the list of final results.
Alternate Designs
We could change
fuzzy-nativeto accept an object that contains both the full path of the result (or an id) + the string to use for the matcher (as the standard fuzzy matcher does), but that would require sending a much bigger object to the native side which could slowdown thing (plus the change would be bigger and affect other repos).Benefits
Fixes https://github.com/atom/fuzzy-finder/issues/382
Possible Drawbacks
None that I can think of.
Applicable Issues
https://github.com/atom/fuzzy-finder/issues/382