Fix excluding VCS ignored paths based on the flag in core settings when ripgrep is enabled

atom / fuzzy-finder

Find and open files quickly

MIT License

274 stars 138 forks source link

Fix excluding VCS ignored paths based on the flag in core settings when ripgrep is enabled #395

Closed nikazooz closed 5 years ago

nikazooz commented 5 years ago

Description of the Change

This fixes a bug when experimental fast mode that uses ripgrep is enabled. Since excluding VCS ignored paths is the default behavior of ripgrep, option to not ignore them was not being passed when needed.

Alternate Designs

N/A

Benefits

Excluding VCS ignored paths from fuzzy search will work a bit more consistently when using ripgrep.

Possible Drawbacks

N/A

Applicable Issues

N/A

50Wliu commented 5 years ago

Thanks @nikazooz! Can you please add a test for this to make sure it doesn't regress in the future?

nikazooz commented 5 years ago

@50Wliu I don't have much experience with writing tests for atom packages, but this should cover the case this PR solves. I'm open to suggestions for improvement if you have any :slightly_smiling_face:

nikazooz commented 5 years ago

Glad I was able to help 🙂 Thank you all for your work on this editor!

50Wliu commented 5 years ago

Travis is having rate limit issues, so I think this is fine to merge.