Symlinks within repository now breaking git-diff

[lucascosti]

Prerequisites

• [x] Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

I have a repo that contain symlinks to other places within the same repo. eg

repo/
└── docs/
       ├── topics/
       └── InstallGuide/
               └── topics/ -> ../topics/

repo/docs/InstallGuide/topics is a symlink to repo/docs/topics.

If I open a file from within the symlinked directory (repo/docs/InstallGuide/topics), then git-diff line marking in the gutter for that file no longer works.

If I open the file from repo/docs/topics, git-diff line marking in the gutter does work.

I'm not sure when it started breaking, but I think it was after I installed 1.14.0. I don't think this is the same issue as #91, as this directory structure has been working fine with git-diff until this week.

Versions

OS is Fedora 24.

$ atom --version Atom : 1.14.1 Electron: 1.3.13 Chrome : 52.0.2743.82 Node : 6.5.0

$ apm --version apm 1.15.3 npm 3.10.5 node 4.4.5 x64 python 2.7.13 git 2.7.4

[50Wliu]

@dirk-thomas is this potentially caused by the path resolution changes?

[dirk-thomas]

Yes, this could be related to atom/atom#13545 which changed the behavior of Project.resolvePath to not resolve symlinks. That method is used in several places under the hood, e.g. a TextEditor uses this too. I am not familiar with the git-diff package but it should be sufficient to resolve the symlink explicitly if it needs to.

[maxbrunsfeld]

This issue was moved to atom/atom#18001