search

atom / git-diff

Diff markers in Atom's gutter
MIT License
102 stars 36 forks source link

git-diff does not follow config for submodule ( ignore = dirty ) #140

Closed terrywh closed 6 years ago

terrywh commented 7 years ago

Description

git-diff does not follow config for submodule ( ignore = dirty )

Steps to Reproduce

  1. config a submodule ( ignore = dirty ), for example:

    [submodule "deps/nghttp2"]
path = deps/nghttp2
url = https://github.com/nghttp2/nghttp2.git
ignore = dirty

  2. touch a new file in that submodule

Expected behavior: do not show update or new file add

Actual behavior: a new file was added and marked green

Reproduces how often: always

Versions

git-diff 1.3.6 Atom x64 1.19.0 (Windows)

maxbrunsfeld commented 6 years ago

We'd probably get this behavior for free if we stopped computing diffs using libgit2 and started using the git executable instead, like the github package does.

maxbrunsfeld commented 6 years ago

This issue was moved to atom/atom#18003